Code Review Meetings
I will meet individually with each of the project teams for one hour
to talk with you about my code review for your Project 1. Here is some
information about those meetings.
- The meetings will take place in my office (Gates 352). Bring a
laptop that you can use to display your code review (we will use a
video projector in my office).
- Set up the laptop to display the pull request comments on one
side of the screen and an IDE on the other side that we can use to
look at the code in question (it's too awkward to look at the code in the
pull request, due to the large number of comments).
- I will want to go over all of the comments I have marked
"Let's discuss." I'm also happy to discuss any other comments that you
wish to discuss (for example, if you don't understand them or disagree
with them).
- Make sure you have read over my review comments before the
meeting. In some cases I will have given you specific issues to
consider; be prepared to discuss those.
- Plan on taking notes during the meeting so that you don't forget
the things we discuss. One approach that has worked well in the past is
for one team member to be the "driver" (their laptop is the one showing
the comments and code) and the other team member to be the "note taker",
for example, by adding additional comments in the pull request.
- When signing up for a meeting slot, make sure you have
enough time to read over my comments and prepare. For example,
your meeting should not be immediately after the class
period when we discuss your project.
- The meetings sometimes run long, so try not to schedule
anything immediately after your meeting slot.