Code Review 3

This round of code reviews will be structured like previous code reviews:

For each project that we review, the developing team will spend 10-15 minutes describing the key design ideas behind a portion of the project (see below for specific topics for each review).
Other students will create written code reviews for the topics specified for the project. You must read the files indicated below, and may read other files as well, if needed to understand the given files. As usual, don't submit your written reviews until after the discussion in class.
Two of the reviewers will spend 3-5 minutes each to present the most important aspects of their review in class.
I will write code reviews for all of the projects.

Schedule

Presenters	Review&Present	Review
Fraser/Jiang	Tollman, Mu	Plattner, Guo, Alexandari
Mogan/Orttung	Torres da Silva, Alexandari	Fraser, Hong, Mu
Plattner/Spiegel	Guo, Mallery	Jiang, Torres da Silva, Spradling, McKinnon
Aboukhadijeh/McKinnon	Hong, Zang	Spiegel, Zheng, Mogan
Mallery/Zang	Spradling, Zheng	Tollman, Aboukhadijeh, Orttung

Review Topics

Here are the particular topic(s) to review for each project, along with a few suggested questions to consider. In addition to these questions, feel free to discuss other design issues, either good or bad, that you notice in reviewing the code.

Fraser/Jiang (proj3-1)

Review the supporting classes used by the main shell engine, including VariableManager TokenList, PathCache, and Command. Are these classes deep? How much do they simplify the development of the main shell engine?

Mogan/Orttung (proj3-2)

Review CommandProcessor, ClashMain, and the interactions between these classes. Is the parsing of shell commands decomposed cleanly within CommandProcessor? Does it properly implement the shell syntax? What do you think of the decomposition between CommandProcessor and ClashMain?

Plattner/Spiegel (proj3-7)

Review ClashPipeline, clash.cc, and the interactions between these classes. Is the parsing of shell commands decomposed cleanly within ClashPipeline? Does it properly implement the shell syntax? What do you think of the decomposition between ClashPipeline and clash.cc?

Aboukhadijeh/McKinnon (proj3-5)

Review the mechanism for parsing commands, including JobParser and related classes. Is the parsing of shell commands decomposed cleanly? Does this approach handle all of the shell syntax features?

Mallery/Zang (proj3-9)

Review the token mechanism, starting with the Token class and working through the other classes that uses Tokens to parse commands. Are tokens cleanly encapsulated, with deep interfaces? How general-purpose are they? How effectively do they support the rest of command parsing?

CS 190: Software Design Studio (Winter 2019)